Skip to content

Local Routing for Separate Redis DB not working (CAN-388) - #144

Draft
Saaketh0 wants to merge 1 commit into
mainfrom
CAN-388-Document-Redis-Contract
Draft

Saaketh0 wants to merge 1 commit into
mainfrom
CAN-388-Document-Redis-Contract

Conversation

@Saaketh0

@Saaketh0 Saaketh0 commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Running a separate Redis DB on the workflow crashed it because it routed to localhost, but we use a docker internal network to connect everything. This is probably generalizable to any DB.

Claude Below:

Summary

  • A ported checkpointer/cache/store client that defaults to localhost silently crashes under CanyonOS, since each agent/workflow gets its own container (hit this porting examples/portfolio_langgraph's LangGraph RedisSaver, CAN-388).
  • Core already injects CANYONOS_REDIS_HOST/CANYONOS_REDIS_PORT into every container on both providers, but the porting-to-canyonos skill's reference docs never told a porting agent to use them.
  • Documents the contract in adapter.md and adds the matching symptom row to troubleshooting.md.

Test plan

  • Docs-only change; no code paths affected.

🤖 Generated with Claude Code

…388)

A ported checkpointer/cache/store defaulting to localhost silently
crashes under CanyonOS, since each agent/workflow gets its own
container. Document the injected CANYONOS_REDIS_HOST/CANYONOS_REDIS_PORT
contract in adapter.md and add the matching symptom to troubleshooting.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Saaketh0 Saaketh0 changed the title Document CANYONOS_REDIS_HOST/PORT contract for backing services (CAN-388) Local Routing for Separate Redis DB not working (CAN-388) Sep 18, 2026
@Saaketh0
Saaketh0 requested a review from nickhuo September 18, 2026 01:51
@Saaketh0 Saaketh0 self-assigned this Sep 18, 2026
@Saaketh0 Saaketh0 added the bug Something isn't working label Sep 18, 2026
@iidsample

Copy link
Copy Markdown
Member

I want to understand this better. Unable to parse what is the problem and what is the fix.

Copy link
Copy Markdown
Collaborator Author

So I made this draft PR last night when I was tired, but looking at it again, it kind of looks to be like it would be fixed by the PR I made to fix CAN-301.

Copy link
Copy Markdown
Collaborator Author

The issue seems to be connection issues for a database connected to the agentic workflow, which I fixed by adding a new "database" type that skips the stub building and image generation done to agents and workflows

nickhuo added a commit that referenced this pull request Sep 25, 2026
* Document CANYONOS_REDIS_HOST/PORT contract for backing services (CAN-388)

A ported checkpointer/cache/store defaulting to localhost silently
crashes under CanyonOS, since each agent/workflow gets its own
container. Document the injected CANYONOS_REDIS_HOST/CANYONOS_REDIS_PORT
contract in adapter.md and add the matching symptom to troubleshooting.md.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* docs: track canyonization app readiness guide

Stop ignoring docs/ so this guide can be reviewed and shared through the repo.

* update docs

* docs: require explicit workflow output resolution in porting guide

* update

* correct

* docs: scope future resolution guidance to workflow outputs

* Clarify dependency pinning guidance in readiness doc

* docs: add readiness gate and concise porting handoff

* update

* feat(skill): write the workflow's test input to .car/config/test_query.txt

Each port now records one eligible workflow input, verbatim, for
end-to-end testing via canyonos test "$(cat .car/config/test_query.txt)".
Also documents that query is always a str and that Future arguments and
.value() results arrive as text regardless of the declared yaml type.

* downgrade w006 to warning

* Split ported agents into one service per framework agent

Replace the smallest-service-map rule in the porting skill with a definition
of what counts as an agent in LangGraph/LangChain sources, how agents group
into services, and how edges between agents move into the workflow.

* docs(skill): align llm-proxy guide with OpenAI/Anthropic streaming support

The proxy relays text/event-stream responses since CAN-356, so token-by-token
reads are no longer a blocker. Note the two remaining caveats: OpenAI stream
usage needs include_usage, and the canyonos test stub does not emulate SSE.

* docs(skill): define agents by the source workflow, not the framework

"The framework" read as CanyonOS itself; service boundaries come from the
control flow of the original workflow being ported.

* docs(skill): rewrap agent decision list

* Revert service-boundary changes from the bundle

Moved to a separate PR so the bundle stays limited to the four bundled PRs.
Reverts a3c1914, c4150dd, and 21cf262.

* docs(skill): address CodeRabbit review on bundle

- Resolve database clients against their declared entry, not the Redis env.
- Link the readiness guide on main instead of a branch commit.
- Exclude .venv from the readiness compile check.

---------

Co-authored-by: Saaketh Sodanapalli <saaketh.s@canyoncode.ai>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Felipe Augustos <felipe_augustos84@outlook.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants