Conversation
…388) A ported checkpointer/cache/store defaulting to localhost silently crashes under CanyonOS, since each agent/workflow gets its own container. Document the injected CANYONOS_REDIS_HOST/CANYONOS_REDIS_PORT contract in adapter.md and add the matching symptom to troubleshooting.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I want to understand this better. Unable to parse what is the problem and what is the fix. |
|
So I made this draft PR last night when I was tired, but looking at it again, it kind of looks to be like it would be fixed by the PR I made to fix CAN-301. |
|
The issue seems to be connection issues for a database connected to the agentic workflow, which I fixed by adding a new "database" type that skips the stub building and image generation done to agents and workflows |
* Document CANYONOS_REDIS_HOST/PORT contract for backing services (CAN-388) A ported checkpointer/cache/store defaulting to localhost silently crashes under CanyonOS, since each agent/workflow gets its own container. Document the injected CANYONOS_REDIS_HOST/CANYONOS_REDIS_PORT contract in adapter.md and add the matching symptom to troubleshooting.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * docs: track canyonization app readiness guide Stop ignoring docs/ so this guide can be reviewed and shared through the repo. * update docs * docs: require explicit workflow output resolution in porting guide * update * correct * docs: scope future resolution guidance to workflow outputs * Clarify dependency pinning guidance in readiness doc * docs: add readiness gate and concise porting handoff * update * feat(skill): write the workflow's test input to .car/config/test_query.txt Each port now records one eligible workflow input, verbatim, for end-to-end testing via canyonos test "$(cat .car/config/test_query.txt)". Also documents that query is always a str and that Future arguments and .value() results arrive as text regardless of the declared yaml type. * downgrade w006 to warning * Split ported agents into one service per framework agent Replace the smallest-service-map rule in the porting skill with a definition of what counts as an agent in LangGraph/LangChain sources, how agents group into services, and how edges between agents move into the workflow. * docs(skill): align llm-proxy guide with OpenAI/Anthropic streaming support The proxy relays text/event-stream responses since CAN-356, so token-by-token reads are no longer a blocker. Note the two remaining caveats: OpenAI stream usage needs include_usage, and the canyonos test stub does not emulate SSE. * docs(skill): define agents by the source workflow, not the framework "The framework" read as CanyonOS itself; service boundaries come from the control flow of the original workflow being ported. * docs(skill): rewrap agent decision list * Revert service-boundary changes from the bundle Moved to a separate PR so the bundle stays limited to the four bundled PRs. Reverts a3c1914, c4150dd, and 21cf262. * docs(skill): address CodeRabbit review on bundle - Resolve database clients against their declared entry, not the Redis env. - Link the readiness guide on main instead of a branch commit. - Exclude .venv from the readiness compile check. --------- Co-authored-by: Saaketh Sodanapalli <saaketh.s@canyoncode.ai> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: Felipe Augustos <felipe_augustos84@outlook.com.br>
Running a separate Redis DB on the workflow crashed it because it routed to localhost, but we use a docker internal network to connect everything. This is probably generalizable to any DB.
Claude Below:
Summary
localhostsilently crashes under CanyonOS, since each agent/workflow gets its own container (hit this portingexamples/portfolio_langgraph's LangGraphRedisSaver, CAN-388).CANYONOS_REDIS_HOST/CANYONOS_REDIS_PORTinto every container on both providers, but the porting-to-canyonos skill's reference docs never told a porting agent to use them.adapter.mdand adds the matching symptom row totroubleshooting.md.Test plan
🤖 Generated with Claude Code